Merged
Conversation
Janther
added
the
performance
Janther
commented
Aug 16, 2025
| this.isEmpty = | ||
| this.arguments.items.length === 0 && // no arguments | ||
| !this.comments.some((comment) => isBlockComment(comment)); // no block comments | ||
| !ast.cst.children().some(({ node }) => isBlockComment(node)); // no block comments |
Member
Author
There was a problem hiding this comment.
this is the only node that has a change that is not removing updateMetadata
Janther
commented
Aug 16, 2025
|
|
||
| // Because of comments being extracted like a russian doll, the order needs | ||
| // to be fixed at the end. | ||
| this.comments = this.comments.sort((a, b) => a.loc.start - b.loc.start); |
Member
Author
There was a problem hiding this comment.
comments are handled at the slangSolidityParser level
fvictorio
approved these changes
Aug 30, 2025
Member
fvictorio
left a comment
fvictorio
left a comment
There was a problem hiding this comment.
Pre-approving with a minor comment.
…prettier will create them if needed and only a few places need to check if it's defined
Janther
force-pushed
the
singleton-comments
branch
from
55eeba4 to
eb411f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of gathering comments at each node and collecting them at the
updateMetadatastep, we store them in a single place and retrieve them at the end of the parsing step.